[GitHub] flink issue #2671: [FLINK-4862] fix Timer register in ContinuousEventTimeTri...

2016-10-24 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2671 Thanks for having a look @aljoscha. Thanks again for the PR @manuzhang. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #2671: [FLINK-4862] fix Timer register in ContinuousEventTimeTri...

2016-10-24 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2671 @mxm @manuzhang Yes, the timers will be ignored because there is a check in `onEventTime()`. The fix looks good! Will you go ahead and merge, @mxm? --- If your project is set up for it,

[GitHub] flink issue #2671: [FLINK-4862] fix Timer register in ContinuousEventTimeTri...

2016-10-21 Thread manuzhang
Github user manuzhang commented on the issue: https://github.com/apache/flink/pull/2671 @mxm updated. Thanks for teaching me more about the internals. Ignoring the old Timer make things much simpler actually. --- If your project is set up for it, you can reply to this email and have