Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2758
The PR looks good. The only thing missing is documentation. I will add it
and merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2758
Great ! The PR looks good to me now, thank you for your contribution !
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user miaoever commented on the issue:
https://github.com/apache/flink/pull/2758
@wuchong sure, fixed :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2758
The Travis CI has failed because of `BuiltInMethods` line length, could
you fix this ?
```
[INFO] --- scalastyle-maven-plugin:0.8.0:check (default) @ flink-table_2.10
---
error
Github user miaoever commented on the issue:
https://github.com/apache/flink/pull/2758
Hi @wuchong, I have resolved the conficts :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2758
It would be great if you can rebase your branch and resolve the conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user miaoever commented on the issue:
https://github.com/apache/flink/pull/2758
Hi @wuchong , I have modified the test cases according to your comments,
please review my latest commit. Thanks :)
---
If your project is set up for it, you can reply to this email and have your
