[GitHub] flink issue #2913: [backport] [FLINK-5114] [network] Handle partition produc...

2016-12-08 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2913 Closing in favour of #2975. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink issue #2913: [backport] [FLINK-5114] [network] Handle partition produc...

2016-12-07 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2913 I removed the `findExecutionAttemptWithId` and only check the latest attempt. If that does not match the expected producer attempt, I answer with a `PartitionProducerDisposedException` to which the

[GitHub] flink issue #2913: [backport] [FLINK-5114] [network] Handle partition produc...

2016-12-05 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2913 > Why is that necessary? Can we not just assume that if the attempt is not equal to the current execution attempt, then the status is some form of "disposed". It's not necessary. It's perfectly

[GitHub] flink issue #2913: [backport] [FLINK-5114] [network] Handle partition produc...

2016-12-05 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2913 Having a quick look at this: I think this breaks with a fundamental design in the ExecutionGraph: The `findExecutionAttemptWithId(...)` method searches the prior execution attempts.