Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2992
I will drop this PR. I think the rebase is worse than a redo in case we
want this at some point.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2992
What's the status of this PR @StefanRRichter ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2992
I will do another pass over it first an then rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2992
@StefanRRichter If you also agree, could you please rebase on the latest
master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2992
+1 for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2992
I made the interface generic and changed the hierarchy as suggested by
@zentol.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2992
Changes look good to me. But I think that @zentol is right that
`AbstractCloseableRegistry` should probably implement the `CloseableRegistry`
interface from an OOP point of view.
---
If your
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2992
CC @tillrohrmann @aljoscha
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
