[GitHub] flink issue #3042: [FLINK-4410] Expose more fine grained checkpoint statisti...

2017-01-09 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3042 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink issue #3042: [FLINK-4410] Expose more fine grained checkpoint statisti...

2017-01-09 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3042 Thanks for checking it out Robert. Would love to merge it for 1.2 as well. I fixed the rounding issue. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #3042: [FLINK-4410] Expose more fine grained checkpoint statisti...

2017-01-09 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3042 Very nice change! I would love to merge it to 1.2 as well, its so helpful! One very minor thing: I would suggest to round the percentages shown for the completion. I had an instance

[GitHub] flink issue #3042: [FLINK-4410] Expose more fine grained checkpoint statisti...

2017-01-09 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3042 I think a triggering delay would be very nice and helpful. We can do this as a next step, separate from this pull request. --- If your project is set up for it, you can reply to this email

[GitHub] flink issue #3042: [FLINK-4410] Expose more fine grained checkpoint statisti...

2017-01-09 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3042 Sorry for the long delay here. We can add that number as a separate column *Triggering Delay*. What do you think? As a follow up I would also like to add documentation about what all the numbers mean.

[GitHub] flink issue #3042: [FLINK-4410] Expose more fine grained checkpoint statisti...

2016-12-30 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3042 Okay, super. The 'time to triggering' is then `end_to_end_time - sync_time - async_time`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink issue #3042: [FLINK-4410] Expose more fine grained checkpoint statisti...

2016-12-24 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3042 Hey Stephan! Thanks for spotting the typo. The numbers are already reported but I forgot to attach the screenshot. They are only reported for each operator/task though, because I'm not sure what would

[GitHub] flink issue #3042: [FLINK-4410] Expose more fine grained checkpoint statisti...

2016-12-23 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3042 I think what would put a cherry on top is if we can break the "End To End Duration" down into - Delay till triggering (how long until all barriers were there) - Synchronous checkpoint

[GitHub] flink issue #3042: [FLINK-4410] Expose more fine grained checkpoint statisti...

2016-12-23 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3042 Wow, this looks awesome, great work. Small note: In screenshot 2, it says "End to Duration", which should probably be "End to End Duration". Is there also a column that shows