[GitHub] flink issue #3313: [FLINK-5588][ml] add a data normalizer to ml library

2017-02-18 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/flink/pull/3313 WIP I will add the unit scaler here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #3313: [FLINK-5588][ml] add a data normalizer to ml library

2017-02-16 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/flink/pull/3313 Ok sorry for that I did squash the commits, also I am used to it from other projects where the comments are invalidated. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #3313: [FLINK-5588][ml] add a data normalizer to ml library

2017-02-16 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3313 But please don't do a force push on a branch which has been opened as a PR. If there was a review ongoing, then the force push might invalidate it (e.g. if you changed something in the relevant

[GitHub] flink issue #3313: [FLINK-5588][ml] add a data normalizer to ml library

2017-02-16 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3313 @skonto another option, if the master branch has a newer commit, is to rebase and force push. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink issue #3313: [FLINK-5588][ml] add a data normalizer to ml library

2017-02-16 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3313 Hi @skonto, if you have activated the Travis integration for your own repo, then you can restart the testing job there. For the apache account it is not possible. However, I've seen that only

[GitHub] flink issue #3313: [FLINK-5588][ml] add a data normalizer to ml library

2017-02-15 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/flink/pull/3313 @tillrohrmann the tests never finished :( Is there a way to re-trigger it besides a commit? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink issue #3313: [FLINK-5588][ml] add a data normalizer to ml library

2017-02-15 Thread thvasilo
Github user thvasilo commented on the issue: https://github.com/apache/flink/pull/3313 Hello @skonto thanks for your contribution! I'm currently snowed under paper deadlines, so I can't give you a time for when I'll be able to go through this, hopefully within the next 2-3

[GitHub] flink issue #3313: [FLINK-5588][ml] add a data normalizer to ml library

2017-02-14 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/flink/pull/3313 @thvasilo @tillrohrmann pls review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled