[GitHub] flink issue #3378: [FLINK-5849] [kafka] Move FlinkKafkaConsumer start offset...

2017-02-27 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3378 Tests pass, merging .. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink issue #3378: [FLINK-5849] [kafka] Move FlinkKafkaConsumer start offset...

2017-02-27 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3378 Thanks for the review @rmetzger! For the moving of `open()` to before `run()`, I've included that as the commit tagged with FLINK-5849. For the star import fix, I'm going to include that

[GitHub] flink issue #3378: [FLINK-5849] [kafka] Move FlinkKafkaConsumer start offset...

2017-02-27 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3378 Rebased on `master`. Note about changes to partition assignment logic in deleted lines 538 - 553 and added lines 563 -565 of `FlinkKafkaConsumerBase`: The change is irrelevant to this