Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3408
Changes look good to me. Thanks for your contribution @WangTaoTheTonic.
Merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/flink/pull/3408
@tillrohrmann
After changing code the test results(both session and single mode) is like:
| Configurations | #vcores of container(TM) |
#slots of TM |
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3408
Yes exactly @WangTaoTheTonic :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/flink/pull/3408
All right. That makes sense. Let me rephrase that and please check if we
are in same channel:
1. slots of taskmanager is decided by `-s/-ys` and
`taskmanager.numberOfTaskSlots`, the
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3408
If I'm not mistaken, then `yarn.containers.vcores` defines the number of
vcores for a container. This, however, is not the same as the number of slots,
since a slot can also have more than one
Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/flink/pull/3408
@tillrohrmann I still cannot get your point entirely. don't this three
configs(`-s/-ys`, `yarn.containers.vcores` and `taskmanager.numberOfTaskSlots`
mean same thing? Do they have difference
Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/flink/pull/3408
@tillrohrmann @StephanEwen
The code was changed and I've verified the functions, could you please
review this and merge it if it's good to go?
---
If your project is set up for
Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/flink/pull/3408
ping @tillrohrmann
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/flink/pull/3408
I move the initiallization of this config to constructor of cluster
descripter and restore the deleted configuration setting.
Please check if we are good with the usage of `YARN_VCORES`.
Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/flink/pull/3408
I'm sorry about the commit message :(
next time I'll format it, as it's better not to squash.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3408
Another remark concerning the commit message. In the Flink community it's
common to format the commit message the following way:
```
[FLINK-] [component tag] Commit message title
11 matches
Mail list logo
