[GitHub] flink issue #3540: [FLINK-6056] [build]apache-rat exclude flink directory in...

2017-03-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3540 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] flink issue #3540: [FLINK-6056] [build]apache-rat exclude flink directory in...

2017-03-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3540 @shijinkui Got it, thanks. +1 to merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3540: [FLINK-6056] [build]apache-rat exclude flink directory in...

2017-03-15 Thread shijinkui
Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/3540 > I am a bit confused... I think there is no tools/flink* directory that would need an exclusion... When execute `tools/create_release_files.sh`, it will clone flink project from apache. A

[GitHub] flink issue #3540: [FLINK-6056] [build]apache-rat exclude flink directory in...

2017-03-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3540 I am a bit confused... I think there is no `tools/flink*` directory that would need an exclusion... --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] flink issue #3540: [FLINK-6056] [build]apache-rat exclude flink directory in...

2017-03-15 Thread shijinkui
Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/3540 > Why exactly is it a problem if the rat-plugin checks the tools directory? There no necessary to check the tmp flink project in the tools, because it will extra cost some time when build the ma

[GitHub] flink issue #3540: [FLINK-6056] [build]apache-rat exclude flink directory in...

2017-03-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3540 Why exactly is it a problem if the rat-plugin checks the tools directory? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec