Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3595
@wenlong88 thanks for the contribution (and the ping)! Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user wenlong88 commented on the issue:
https://github.com/apache/flink/pull/3595
hi, @greghogan , do you have any new comment about the changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user wenlong88 commented on the issue:
https://github.com/apache/flink/pull/3595
@greghogan I come across this bug when we are trying to write some objects
to a byte array: at first, I wrote a 0 as initial size and then the serialized
object, after that, I seek back to the star
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3595
@wenlong88 you are right that the position can currently be moved beyond
written data. This still feels a bit like feature creep as we've added to the
PR. Do you need to expand the array is this ma
Github user wenlong88 commented on the issue:
https://github.com/apache/flink/pull/3595
@greghogan Currently we check the position with the EndPosition which is
the size of buffer instead of a max written size , so it is still possible to
leave holes when keeping unmodified. Enabling
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3595
When expanding with `write` the new capacity (up to `position` of course)
is filled with data. Expanding with `setPosition` can leave holes in the data
and may mask a bug. Since these classes are u
Github user wenlong88 commented on the issue:
https://github.com/apache/flink/pull/3595
@greghogan Thanks for the review. I have add non-negative check and update
the test with ExpectedException. But I don't think we need to call toString in
the test since we have check the position i
Github user wenlong88 commented on the issue:
https://github.com/apache/flink/pull/3595
hi, @StefanRRichter , I have add check in setPosition in
ByteArrayInputSteamWithPos, there is no dependency on this method too, so I
rename the method from setPos to setPosition for unifying.
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3595
I would suggest to introduce the analogue check also in
`ByteArrayInputStreamWithPos`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user wenlong88 commented on the issue:
https://github.com/apache/flink/pull/3595
@greghogan comments addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user wenlong88 commented on the issue:
https://github.com/apache/flink/pull/3595
@greghogan thanks for the review, I have changed the change test to use
explicit buffer size.
you are right that currently there is no dependency on this method. We used
the ByteArrayOutputStre
11 matches
Mail list logo
