Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3598
Thanks, I'll take it from here...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user fpompermaier commented on the issue:
https://github.com/apache/flink/pull/3598
Now it should be ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3598
I would do the following:
- log nothing
- Catch the errors that are regular "move failed" exceptions and return
false.
- `FileNotFoundException`
- `DirectoryNotEmptyE
Github user fpompermaier commented on the issue:
https://github.com/apache/flink/pull/3598
Of course..but how should I handle them? should I catch just one exception?
What should I log?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3598
@fpompermaier have you addressed the comment @StephanEwen regarding logging?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user fpompermaier commented on the issue:
https://github.com/apache/flink/pull/3598
Anyone willing to merge this PR...?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3598
I think we don't need the logging in all of the cases. We typically avoid
logging in "utility functions", which are missing the context if the exception
is in fact a problem worth mentioning, of
Github user fpompermaier commented on the issue:
https://github.com/apache/flink/pull/3598
Does the current exception handling address your comments @StephanEwen?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
