[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

Github user zentol commented on the issue: https://github.com/apache/flink/pull/3720 merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/3720 Yes, let's get this done. On Jun 6, 2017 19:03, "Stephan Ewen" wrote: > @alpinegizmo @zentol > Now that #4043

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3720 @alpinegizmo @zentol Now that #4043 is merged, can we rebase this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/3720 This looks good, thank you. However, I now understand what was going on with the downgrade of the octokit dependency. I think we should first merge https://github.com/apache/flink/pull/4043 and t

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3720 @StephanEwen I think it is the best way to solve this issue. I will follow the suggestion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3720 @mtunique What do you think about @alpinegizmo 's suggestion? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/3720 I prefer a conservative approach for as long as we still have to support building the docs on Ruby 1.9, so I'd keep the number of updated gems as small as possible. As for adding support

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

Github user zentol commented on the issue: https://github.com/apache/flink/pull/3720 The `GemFile` should be updated as well. It would still work as long as the `GemFile.lock` file is present. If it deleted however the bundler would load the dependencies from `GemFile` and create a ne

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3720 I am not familiar with the Ruby / Bundler / etc space, but it looks like `Gemfile` is the original source of truth and `Gemfile.lock` is in some way derived from that. Is it correct to only u

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

Github user zentol commented on the issue: https://github.com/apache/flink/pull/3720 I can confirm that you can build the docs on W10 with the Linux Subsystem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

Github user haohui commented on the issue: https://github.com/apache/flink/pull/3720 +1 (non-binding) Tested on OSX Sierra. The documentation builds successfully. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

Github user haohui commented on the issue: https://github.com/apache/flink/pull/3720 I hit the same problem on my Mac. Let me try it out later today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3720 Would be great if someone else could confirm that this works. Ideally, we get a +1 from a Linux user, a MacOS X user, and a Cygwin user... --- If your project is set up for it, you can reply to