[GitHub] flink issue #3741: [FLINK-6177] Add support for "Distributed Cache" in strea...

2017-05-03 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3741 merging. will add the missing space while I'm doing it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3741: [FLINK-6177] Add support for "Distributed Cache" in strea...

2017-04-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3741 Looks quite good now. If I can ask you for one more followup: To have faster tests, it would be good to add the streaming distributed cache test and the batch distributed cache test to

[GitHub] flink issue #3741: [FLINK-6177] Add support for "Distributed Cache" in strea...

2017-04-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3741 @zohar-pm You don't have to open a new one, feel free to update the branch in this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink issue #3741: [FLINK-6177] Add support for "Distributed Cache" in strea...

2017-04-19 Thread zohar-pm
Github user zohar-pm commented on the issue: https://github.com/apache/flink/pull/3741 No problem. Will follow it and will create a new pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #3741: [FLINK-6177] Add support for "Distributed Cache" in strea...

2017-04-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3741 Thanks for contributing this, the added functionality looks good. I would prefer to add this change without changing the dependencies and test base classes. You could for example change