Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3748
Thanks for the update @PangZhi.
Btw. it is recommended to post a short comment when you update a PR.
Pushing an update does not trigger a notification.
The PR looks good. Will merge
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3748
Thanks for the update and reminder @PangZhi.
I'll have a look tomorrow. Maybe we can include this in the upcoming 1.4.0
release.
Thanks, Fabian
---
Github user PangZhi commented on the issue:
https://github.com/apache/flink/pull/3748
@zentol Hey zentol, when do you think we will be able to merge in.
---
Github user PangZhi commented on the issue:
https://github.com/apache/flink/pull/3748
@zentol thx, fixed.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3748
```
[ERROR]
src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraRowSink.java:[20,8]
(imports) UnusedImports: Unused import:
org.apache.flink.configuration.Configuration.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3748
A few minor things left, but we're in pretty good shape now.
---
Github user PangZhi commented on the issue:
https://github.com/apache/flink/pull/3748
@zentol @fhueske Can you take another look.
---
Github user PangZhi commented on the issue:
https://github.com/apache/flink/pull/3748
@zentol Do you mind taking another look.
---
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3748
Given we have dropped the support for Java 7, it might make sense to just
rewrite the class to use the completablefuture in java 8.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3748
When importing guava you have to explicitly add an exclusion to
https://github.com/apache/flink/blob/master/tools/maven/suppressions.xml.
---
Github user PangZhi commented on the issue:
https://github.com/apache/flink/pull/3748
@fhueske Hi zentol hasn't replied can you help to take a look. thx
---
Github user PangZhi commented on the issue:
https://github.com/apache/flink/pull/3748
@zentol and do you know why import
com.google.common.util.concurrent.ListenableFuture becomes illegal import? The
checkstyle error is blocking CI. However this class is brought in from base
class.
Github user PangZhi commented on the issue:
https://github.com/apache/flink/pull/3748
@zentol can you take another look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3748
Apart from the above this looks ok to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3748
You will have to rebase this PR and adjust the tests. I recently modified
the cassandra tests to no longer run any actual jobs.
---
If your project is set up for it, you can reply to this email and
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3748
@zentol can you please take another look? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
16 matches
Mail list logo
