[GitHub] flink issue #4277: [FLINK-6667] Pass a callback type to the RestartStrategy,...

2017-07-23 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4277 Thank you for your merging, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #4277: [FLINK-6667] Pass a callback type to the RestartStrategy,...

2017-07-23 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4277 Thank you for the contribution! The code form this PR has been improved and merged in this commit: 65400bd0a0f6a3bdd3e0bad05e2179534eaf6e9e If you agree, could you close this PR?

[GitHub] flink issue #4277: [FLINK-6667] Pass a callback type to the RestartStrategy,...

2017-07-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4277 I have taken and adapted the code for the patch in #4364 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #4277: [FLINK-6667] Pass a callback type to the RestartStrategy,...

2017-07-17 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4277 Thank you for your reply, I will fix [FLINK-6665](https://issues.apache.org/jira/browse/FLINK-6665) after this PR is merged, thanks :) --- If your project is set up for it, you can reply to this

[GitHub] flink issue #4277: [FLINK-6667] Pass a callback type to the RestartStrategy,...

2017-07-17 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4277 @zjureel Thanks for this patch. I will pick it up from here. I think there is a small additional change needed, and a test, but I can do that... --- If your project is set up for it, you

[GitHub] flink issue #4277: [FLINK-6667] Pass a callback type to the RestartStrategy,...

2017-07-06 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4277 @StephanEwen @tillrohrmann As discussed in https://github.com/apache/flink/pull/4220, I create this PR to fix issue [FLINK-6667](https://issues.apache.org/jira/browse/FLINK-6667). Could you please