[GitHub] flink issue #4372: [FLINK-7234] [docs] Fix CombineHint documentation

2017-07-22 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4372 @fhueske I started running some benchmarks on HITS with each of the combiners (sort, hash, none) and at small scales hash is fasted followed by none with sort in last. None is somewhat faster than

[GitHub] flink issue #4372: [FLINK-7234] [docs] Fix CombineHint documentation

2017-07-21 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4372 I think you are right @greghogan. It's not about the ratio of #distinct keys to size of the dataset. But it's also not only the ratio of #distinct keys to size of the memory. The skew of

[GitHub] flink issue #4372: [FLINK-7234] [docs] Fix CombineHint documentation

2017-07-21 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4372 @StephanEwen I like the new template. I much prefer free form over checkboxes. @fhueske I'm questioning my understanding of the the heuristic for using a hash-combine. For a fixed number

[GitHub] flink issue #4372: [FLINK-7234] [docs] Fix CombineHint documentation

2017-07-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4372 Thanks for trying out the discussed template @greghogan I think for docs, you can invoke the *(The sections below can be removed for hotfixes of typos)* clause ;-) --- If your project

[GitHub] flink issue #4372: [FLINK-7234] [docs] Fix CombineHint documentation

2017-07-19 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4372 One minor comment. Otherwise +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature