[GitHub] flink issue #4374: repalce map.put with putIfAbsent

2017-11-28 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4374 but honestly, the previous approach just looks wrong: adding it and in case of a conflict reverting that `put` operation. What if (and I'm walking in the dark here) something already operates on

[GitHub] flink issue #4374: repalce map.put with putIfAbsent

2017-11-28 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4374 @RebornHuan although this change looks to be correct and makes good use of the newer API, there is a trade-off between deleting a line of code called during an error condition and the risk of such

[GitHub] flink issue #4374: repalce map.put with putIfAbsent

2017-07-25 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4374 @RebornHuan please provide a brief description of the purpose of this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink issue #4374: repalce map.put with putIfAbsent

2017-07-25 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4374 Although this totally makes sense and would be nice to change, we cannot merge it until Java 7 has been dropped (as you see from the TravisCI runs). --- If your project is set up for it, you can