[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...

2017-11-29 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4383 Thanks @greghogan! ---

[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...

2017-11-28 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4383 @zentol @fhueske I am merging the change with the extra space since this looks to have been the original intent. I've looked at both forms without finding a strong preference. ---

[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...

2017-07-25 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4383 I have no strong opinion on this. Either way is fine as long as it is consistent ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...

2017-07-25 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4383 Dropping the space may make it easier to fix the line splitting issue in the web UI. @fhueske thoughts? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...

2017-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4383 I think i prefer the version without a space, but I may just be looking at it from a metrics perspective (yay, one less special character to deal with). --- If your project is set up for it, you can

[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...

2017-07-24 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4383 @zentol I'd estimate that to be a similar change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...

2017-07-24 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4383 Just to mention the idea, would removing the space introduce more changes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...

2017-07-24 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4383 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if