Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4415
@EronWright the driving rationale is that the static variable is an anti
pattern which can cause problems which are hard to track and understand. E.g.
it is really hard to find out where the
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/4415
There is only one true fix, that is to propagate the configuration instance
everywhere so that only the entrypoint calls loadConfiguration.
---
If your project is set up for it, you can reply to
Github user EronWright commented on the issue:
https://github.com/apache/flink/pull/4415
@tillrohrmann @zentol the whole reason for the static field is to allow the
various sites that call GlobalConfiguration.loadConfiguration to obtain the
dynamic properties.Any property could
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4415
Thanks for your work @zjureel and sorry that it took me so long to get back
to you. Will be merging your PR now.
---
If your project is set up for it, you can reply to this email and have your
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4415
@tillrohrmann Great, use `loadConfigurationWithDynamicProperties` instead
of `loadConfiguration` and `setDynamicProperties` will be more concise, it
sounds good to me, thanks
---
If your project
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4415
@tillrohrmann Thank you for your suggestion, I have update the PR template
and add test caseï¼ thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4415
Thanks for your contribution @zjureel. Could you please fill out the PR
template? This will speed up review work significantly.
---
If your project is set up for it, you can reply to this
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4415
@tillrohrmann @aljoscha I create this PR and try to fix
[https://issues.apache.org/jira/browse/FLINK-7269](https://issues.apache.org/jira/browse/FLINK-7269),
could you please have look when you're
