[GitHub] flink issue #4513: [FLINK-6938][FLINK-6939] [cep] Not store IterativeConditi...

2017-08-21 Thread dianfu
Github user dianfu commented on the issue: https://github.com/apache/flink/pull/4513 Thanks @dawidwys for the remind. Yes, you're right and that make sense to me. I will update the the PR and remove ConditionRegistry related changes. --- If your project is set up for it, you can

[GitHub] flink issue #4513: [FLINK-6938][FLINK-6939] [cep] Not store IterativeConditi...

2017-08-21 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4513 Hmm, I read back all the comments to previous PRs and I think the consesus was that we do not want to introduce the ConditionRegistry at that time, but start with just FLINK-6938 to enable SQL

[GitHub] flink issue #4513: [FLINK-6938][FLINK-6939] [cep] Not store IterativeConditi...

2017-08-16 Thread dianfu
Github user dianfu commented on the issue: https://github.com/apache/flink/pull/4513 @dawidwys @kl0u In case you missed this PR, could you help to take a look at? Very appreciated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink issue #4513: [FLINK-6938][FLINK-6939] [cep] Not store IterativeConditi...

2017-08-10 Thread dianfu
Github user dianfu commented on the issue: https://github.com/apache/flink/pull/4513 As discussed with @wuchong offline, I will continue the work of #4145 as this is required by the feature of cep on sql, see the PR of FLINK-7062 for details. @dawidwys @kl0u Could you help