[GitHub] flink issue #4532: [FLINK-7337] [table] Refactor internal handling of time i...

2017-08-23 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4532 Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink issue #4532: [FLINK-7337] [table] Refactor internal handling of time i...

2017-08-15 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4532 I'm +1 to merge this. I have create two followup issue, we can move the discussion under the JIRA: (1) FLINK-7446 Support to define an existing field as the rowtime field for

[GitHub] flink issue #4532: [FLINK-7337] [table] Refactor internal handling of time i...

2017-08-14 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4532 @wuchong @fhueske I hope I addressed all code related issues. Is it ok to merge this for now? I will create a follow up issue for the Table to DataStream/TableSink conversion case. >