[GitHub] flink issue #4691: [FLINK-7647] [flip6] Port JobManagerConfigHandler to new ...

2017-09-26 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4691 Thanks a lot for the review @tillrohrmann. I'll go ahead and merge this PR after addressing your comments. ---

[GitHub] flink issue #4691: [FLINK-7647] [flip6] Port JobManagerConfigHandler to new ...

2017-09-21 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4691 Sorry about that, local Travis tests pass, should be fine now. ---

[GitHub] flink issue #4691: [FLINK-7647] [flip6] Port JobManagerConfigHandler to new ...

2017-09-21 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4691 Still failing with `ClusterConfigHandlerTest.testGetPaths:32 NullPointer` ---

[GitHub] flink issue #4691: [FLINK-7647] [flip6] Port JobManagerConfigHandler to new ...

2017-09-21 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4691 @tillrohrmann I've corrected checkstyles violations and rebased. ---

[GitHub] flink issue #4691: [FLINK-7647] [flip6] Port JobManagerConfigHandler to new ...

2017-09-21 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4691 Thanks for your contribution @tzulitai. There are still some checkstyle violations in the code. ---