Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4742
Thanks for fixing the failing test cases @zentol. Travis passed. Merging
this PR.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4742
@tillrohrmann We got some test-failures for the CLIFrontend caused by us
now using the ClusterClient for stop/cancel. This is purely a test construction
issue, and I'm currently fixing them.
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4742
Awesome ð Once Travis gives green light, I think we are good to merge
your PR :-)
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4742
@tillrohrmann I rebased the branch (the travis failure actually occurred on
the branch after an auto-rebase by GitHub...) and now use the
ExecutorThreadFactory.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4742
@tillrohrmann I've addressed the second round of comments.
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4742
@zentol there are some checkstyle violations
```
[ERROR]
src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:[314]
(regexp) RegexpSingleline: Trailing whitespace
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4742
@tillrohrmann I've addressed the majority of your comments.
---
