Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4844
Thanks for the review @StephanEwen. I will address your comments and then
merge this PR.
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4844
Had an offline discussion with @tillrohrmann - rewriting this without
Mockito results in a similar amount of code with similar maintenance effort, so
seems to be okay in this case.
+1
Github user zhenzhongxu commented on the issue:
https://github.com/apache/flink/pull/4844
@tillrohrmann created https://issues.apache.org/jira/browse/FLINK-7894
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4844
@zhenzhongxu what kind of metrics would you be interested in? I think we
should open a dedicated issue for that.
---
