[GitHub] flink issue #4988: [FLINK-8030] Instantiate JobMasterRestEndpoint in JobClus...

2017-12-13 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4988 Thanks for the review @shuai-xu and @GJL. Merging this PR after Travis gives green light. ---

[GitHub] flink issue #4988: [FLINK-8030] Instantiate JobMasterRestEndpoint in JobClus...

2017-12-01 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4988 Actually we cannot change it to `0.0.0.0`, because the address is also used by the client to connect to the rest server. Therefore, it must be a valid target address. ---

[GitHub] flink issue #4988: [FLINK-8030] Instantiate JobMasterRestEndpoint in JobClus...

2017-12-01 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4988 Thanks for the review @shuai-xu. I'll change the default value of the rest address to `0.0.0.0`. ---

[GitHub] flink issue #4988: [FLINK-8030] Instantiate JobMasterRestEndpoint in JobClus...

2017-11-30 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/4988 This pr is very helpful for us. Thank you. I have tried it on our cluster with yarn job mode,and it works well. My only suggestion is to change the default value of rest.address to 0.0.0.0 instead