[GitHub] flink issue #5123: [FLINK-8201] YarnResourceManagerTest causes license check...

2018-01-12 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5123 Thanks for the update @wenlong88. The fix looks good to me. Merging this PR once Travis gives green light. ---

[GitHub] flink issue #5123: [FLINK-8201] YarnResourceManagerTest causes license check...

2018-01-12 Thread wenlong88
Github user wenlong88 commented on the issue: https://github.com/apache/flink/pull/5123 @tillrohrmann sorry for the late update. you are right, I have change the pr to just removing the temporary file after uploaded to hdfs. ---

[GitHub] flink issue #5123: [FLINK-8201] YarnResourceManagerTest causes license check...

2017-12-06 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5123 Thanks for the contribution @wenlong88. I was wondering whether the actual problem isn't that we create a new resource (`taskmanager-conf.yaml`) in the working directory which we later don't

[GitHub] flink issue #5123: [FLINK-8201] YarnResourceManagerTest causes license check...

2017-12-05 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5123 Ok, sounds good to me. @tillrohrmann could you please have a look at this? It's a very small change but I know too little about these parts to be sure that it doesn't cause other problems. ---

[GitHub] flink issue #5123: [FLINK-8201] YarnResourceManagerTest causes license check...

2017-12-05 Thread wenlong88
Github user wenlong88 commented on the issue: https://github.com/apache/flink/pull/5123 @aljoscha yes, the task manager config file is created in $PWD dir, and files created in temporary folder will be cleared automatically by junit. ---

[GitHub] flink issue #5123: [FLINK-8201] YarnResourceManagerTest causes license check...

2017-12-05 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5123 So adding it to the `env` will make sure that it's deleted after the test is finished? ---