[GitHub] flink issue #5174: [FLINK-8274][TableAPI & SQL] Fix Java 64K method compilin...

2018-02-28 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5174 @Xpray Yes, I think for a long term solution we should move some variables in the member area but I don't know if it makes sense to move all local variables there. We should fix the `expandLocalRef`

[GitHub] flink issue #5174: [FLINK-8274][TableAPI & SQL] Fix Java 64K method compilin...

2018-02-28 Thread Xpray
Github user Xpray commented on the issue: https://github.com/apache/flink/pull/5174 Thanks @twalthr, that's great, I'm also working on another issue trying to move all local variables to class field, that'll make code split more convenient. ---

[GitHub] flink issue #5174: [FLINK-8274][TableAPI & SQL] Fix Java 64K method compilin...

2018-02-28 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5174 Thanks for the PR @Xpray and the review @walterddr. I also looked over the changes and saw multiple issues that need to be fixed. If it is ok for you, I would add some commits to this one and open a