[GitHub] flink issue #5183: [FLINK-8295][cassandra][build] properly shade netty for t...

2017-12-20 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5183 I tested it locally. Will merge this now... ---

[GitHub] flink issue #5183: [FLINK-8295][cassandra][build] properly shade netty for t...

2017-12-20 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5183 Thanks for the fix @NicoK. I will have a look at it later today and merge this. ---

[GitHub] flink issue #5183: [FLINK-8295][cassandra][build] properly shade netty for t...

2017-12-20 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/5183 true - I adapted the comment accordingly ---

[GitHub] flink issue #5183: [FLINK-8295][cassandra][build] properly shade netty for t...

2017-12-19 Thread mcfongtw
Github user mcfongtw commented on the issue: https://github.com/apache/flink/pull/5183 +1 for this change, @NicoK . I did not see this error as I was working on FLINK-6805 - my bad :(. Also, you might want to remove those comment to avoid future confusion. ---