[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...

2018-03-11 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5371 Actually , I want do some test under the latest master code. ---

[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...

2018-03-11 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5371 Hi, @StephanEwen .Sorry for later. 1. For the first question, I do not have a machine for this test at this moment and wont test it until I have a linux machine. Can not get a linux

[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...

2018-03-09 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5371 Two more questions about this: 1. There is code in the shell scripts that rotates log file each time you start / stop the cluster, with .0 /.1/.2/etc suffixes to the log files. Have

[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...

2018-02-02 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5371 Thanks @StephanEwen review. Yea, You correct. DailyRollingFileAppender doesn't support MaxFileSize, RollingFileAppender does. I will changed the code to a correct version and wait for the CI

[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...

2018-02-02 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5371 The CI Server reports the following problem below. Apparently the configurations cause warnings to be printed. Can you have a look at that? ``` Found non-empty .out files:

[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...

2018-01-31 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5371 Changed! ---

[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...

2018-01-30 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5371 I watched and the Travis error does not relevant to this issue. ---

[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...

2018-01-30 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5371 I have changed the code, @StephanEwen @XuMingmin Welcome to review those codes ~ Thanks. I make the ```MaxFileSize``` to 200MB and storage for 30 days now. ---

[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...

2018-01-29 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5371 Thanks @StephanEwen ~ ---

[GitHub] flink issue #5371: [FLINK-8357] [conf] Enable rolling in default log setting...

2018-01-29 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5371 Looks good! ---