Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5378
merging,
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5378
LGTM, once Travis is green.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5378
Added a test for the `ElasticSearchSinkBase` that passes an unmodifiable
map containing all properties that we currently try to remove.
I also modified the `ElasticSearchTestBase` to pass an
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5378
I'll add a test where we pass an unmodifiable map to the sink, that should
cover it.
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5378
Looks good, but can this be guarded by a test?
Otherwise I can see a someone in the future going like "oh, I have an idea
how to 'optimize' this" and remove that copying operation.
---
