Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5488
Okay ð
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5488
All right, trying to merge this for 1.6
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5488
Sup ?
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5488
Hi, @StephanEwen and @greghogan I think this patch is ready for having
another review now. Could you please ? Thank you. And the CI error does not
relevant to this issue itself.
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5488
I put this upgrade dependency tree here for a reference.
```[INFO] -< org.apache.flink:flink-hbase_2.11
>--
[INFO] Building flink-hbase 1.6-SNAPSHOT
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5488
Thanks you very much @StephanEwen and @greghogan . When I am free, I will
take a look and verify on hbase 1.4.2.
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5488
@zhangminglei You are right, the dependencies should have been excluded
back then. But better to fix later than never ;-)
For the dependencies to exclude, it is hard to find that out. I
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5488
I haven't looked at the changelog but HBase 1.4.2 was released a few weeks
ago.
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5488
@StephanEwen I would ask , what way you used for judging exclude those
dependencies (jersey, jruby, tomcat) ? I used ```mvn dependency:analyze```
under
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5488
Yeah. Actually, We had those dependencies when 1.3.1. We should exclude
them at that time. But we did not.
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5488
Okay, seems we cannot exclude hbase server (hell, hadoop projects really
mess up their dependencies).
Can you try to exclude some of the dependencies, like jersey, jruby,
tomcat, etc?
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5488
Thanks!
The dependency tree is huge, and a good amount is for
`org.apache.hbase:hbase-server`. Is that really needed for the connector, or
can we exclude that?
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5488
Sup ?
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5488
I paste the the 1.3.1 and 1.4.1 ```flink-hbase``` pom dependency tree
respectively below.
I watched the difference between the two dependencies. But I would hope
@StephanEwen can see
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5488
Just to be safe, could you paste the diff in the dependency tree of the
`flink-hbase` project before and after this change?
Always good to know which additional dependencies one pulls in
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/5488
Should be good after 1.4.1 is filled in
---
16 matches
Mail list logo
