Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5568
Merging ..
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5568
I think this is good to go! ð
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5568
Thank you very much @tzulitai I am so happy to hear that. :)
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5568
@aljoscha I've made a few extra changes, and made sure that the end-to-end
test fails properly without the fix:
- use the correct data formats in the Kafka e2e test
- allows the e2e test to
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5568
@zhangminglei yes, that is correct.
---
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5568
Yes. Solved my end-to-end test doubt. But I would like to ask another
question about child-first classloading in this issue. My understand is , If I
submitted a flink application jar to flink
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5568
@zhangminglei the `ClassLoaderTestProgram`, AFAIK, tests parent/child first
classloading.
If what you are concerned about is that there is no end-to-end test for
this fix, it is actually
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5568
Use ```ClassLoaderTestProgram.java``` do that test ?
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5568
@aljoscha yes, I ran a cluster job execution with and without the
classloader fix. It fails before the fix.
Merging this now to `master` and `release-1.4`.
---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5568
The changes look good! Did you try running the end-to-end test without the
fix? If yes and they were failing before the fix I'd say this is good to go.
---
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5568
cc @aljoscha
---
11 matches
Mail list logo
