[GitHub] flink issue #5662: [FLINK-8854] [table] Fix schema mapping with time attribu...

2018-03-09 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/5662 Thanks for the explanation, @twalthr! I'll update the PR and resolve the conflicts caused. ---

[GitHub] flink issue #5662: [FLINK-8854] [table] Fix schema mapping with time attribu...

2018-03-09 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5662 Thanks for the comments @xccui. It's never to late for feedback. Sorry, maybe I merged this too quickly. We still need to call `builder.forJsonSchema()` if the schema contains a `proctime`

[GitHub] flink issue #5662: [FLINK-8854] [table] Fix schema mapping with time attribu...

2018-03-09 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5662 Merging... ---