[GitHub] flink issue #5701: [FLINK-8703][tests] Port SavepointMigrationTestBase to Mi...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5701 Sure @zentol. Won't squash them. Thanks for your work. Merging once Travis gave green light. ---

[GitHub] flink issue #5701: [FLINK-8703][tests] Port SavepointMigrationTestBase to Mi...

2018-03-20 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5701 @tillrohrmann done. I wouldn't squash the savepoint port commit with the accumulator changes though. ---

[GitHub] flink issue #5701: [FLINK-8703][tests] Port SavepointMigrationTestBase to Mi...

2018-03-20 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5701 let me quickly address the `getCOnfigurationSafe` comment and then let's merge them together. ---

[GitHub] flink issue #5701: [FLINK-8703][tests] Port SavepointMigrationTestBase to Mi...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5701 What about the other commit @zentol? Do you want me to commit them separately? I guess it would be easiest to commit everything together. ---

[GitHub] flink issue #5701: [FLINK-8703][tests] Port SavepointMigrationTestBase to Mi...

2018-03-20 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5701 @tillrohrmann I've addressed your comments regarding the accumulator commit. ---