Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/5718
Thanks!
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5718
merging.
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5718
Having a custom timeout like @zentol suggests could be helpful in the long
run.
For now, though, I personally agree that the timeouts are counter
productive (I actually never understood
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/5718
In that case can we merge it as it is and if you want @zentol, we can start
a discussion about future direction of this?
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5718
I don't want to make a fuss over a single test, so for the purposes of this
test it's fine to just remote the timeout.
In general however i think it would be pretty neat if we would add such
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5718
I agree with @pnowojski. The watchdog and Travis itself should time out the
test for us if things take too long.
---
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/5718
I think that timeouts in IDE are only making things worse:
1. you can not debug, since longer debugging session will fail
2. in case of deadlocks, locally you can always manually dump/view
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5718
This change appears to be focus mostly around Travis which i dislike a bit.
I'd rather add a custom `Timeout` that prints the thread-dump so we still
get nice behavior when running things
