[GitHub] flink issue #5867: [FLINK-8686] [sql-client] Improve basic embedded SQL clie...

2018-04-25 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5867 Thank you for the feedback. I will merge the first 5 commits and will open a new PR for an additional configuration file. ---

[GitHub] flink issue #5867: [FLINK-8686] [sql-client] Improve basic embedded SQL clie...

2018-04-19 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/5867 Hi @twalthr , IMO, it's better to seperate the configuration of SQL client from the configuration of the Flink job. From the user's perspective, many of them probably do not need to know

[GitHub] flink issue #5867: [FLINK-8686] [sql-client] Improve basic embedded SQL clie...

2018-04-18 Thread walterddr
Github user walterddr commented on the issue: https://github.com/apache/flink/pull/5867 Hi @twalthr, having JVM heap size configurable is definitely a great benefit. Just to clarify, this is only changing the Client JVM heap size, correct? I am assuming this is mainly for

[GitHub] flink issue #5867: [FLINK-8686] [sql-client] Improve basic embedded SQL clie...

2018-04-18 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5867 @fhueske @walterddr @suez1224 I added the possibility to make the JVM heap size configurable. After a short offline discussion with @StephanEwen, I'm not sure if we should add such configuration to