[GitHub] flink issue #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHandler t...

2018-04-24 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5893 I'll address the remaining issues myself when merging, thanks for working on this! ---

[GitHub] flink issue #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHandler t...

2018-04-23 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5893 @zentol thanks you. I updated the code. :laughing: ---

[GitHub] flink issue #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHandler t...

2018-04-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5893 see `JobVertexDetailsInfo` on how to use it. ---

[GitHub] flink issue #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHandler t...

2018-04-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5893 You have to use the `JobVertexIDSerializer` for that field. ---

[GitHub] flink issue #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHandler t...

2018-04-23 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5893 i saw legacy/SubtasksAllAccumulatorsHandler.java used gen.writeStringField("id", jobVertex.getJobVertexId().toString());. if i change the type of `SubtasksAllAccumulatorsInfo#jobVertexId` to

[GitHub] flink issue #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHandler t...

2018-04-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5893 You have not changed the type of `SubtasksAllAccumulatorsInfo#jobVertexId` to `JobVertexID`. ---

[GitHub] flink issue #5893: [FLINK-9212][flip6] Port SubtasksAllAccumulatorsHandler t...

2018-04-23 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5893 @zentol thanks for your review. I have updated the PR. ---