Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5959
merging.
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5959
LGTM ð
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5959
Sounds good. After the mentioned changes this looks ready to merge for me
ð
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5959
The methods have been identical since FLINK-7692, but I didn't catch it in
the review. Thus, `ComponentMetricGroup#getAllVariables()` should be removed,
along with
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5959
I have two quick questions:
- Why does `ComponentMetricGroup` even override the method
`getAllVariables` from `AbstractMetricGroup` with essentially the exact same
code?
-Why is it
