Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5996
@StephanEwen I would appreciate it if you do the review after my changes!
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5996
@StephanEwen PR is updated as requested! I would appreciate if you review.
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5996
@StephanEwen I updated the code and used `ExecutionContext.global` which
makes use of threadpool.
I tested it and results showed that the code sent off multiple requests
concurrently
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5996
@StephanEwen Thanks for review.
make sense, I will update the client code to use Threadpool and will run
more tests.
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5996
Async I/O works best with asynchronous clients. For synchronous client, you
need a threadpool or something else to concurrently fire off requests.
---
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5996
I had a quick look at the code example, and it looks like it might not
actually do asynchronous I/O.
It dispatches a synchronous HTTP request on a direct executor
(`onComplete`s in a direct
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5996
@zentol I would appreciate if you review this. We use this type of example
for enriching our Steam data via API call which is very common use-case and I
think it would be useful for other people to
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5996
@tzulitai I would appreciate if you review this.
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5996
@StephanEwen please review
---
