Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6081
Thanks for the contribution! Merged.
---
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6081
ð Yes, I have already approved it on github:
> pnowojski approved these changes 23 hours ago
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6081
cc @pnowojski does this PR look good to you?
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6081
@pnowojski test error has fixed~
---
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6081
cc @pnowojski please review this, thanks~
---
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6081
@yanghua why is it difficult? Can not you create more or less similar test
to @GJL's `testSetsUserCodeClassLoader` from here:
https://github.com/apache/flink/pull/4980/files. With couple side
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6081
@pnowojski I've tried but it seams it's hard to do this. The class loader
can not be accessed out of the class. @GJL any suggestion? Or need to test?
---