[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...

2018-07-02 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6123 OK, yes, this PR really make the binary package size more bigger. Closing this issue... ---

[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...

2018-07-02 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/6123 I'm with Till here. The example JARs add very little value. I would be OK with adding them if this was lightweight, but each example will include the Table API and its dependencies (incl. Calcite

[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...

2018-06-29 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6123 hi @tillrohrmann I think we should include the table example jar into Flink's binary distribution just like `batch`, `streaming`, `gelly`, `python` examples for those people who do not want to try

[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...

2018-06-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/6123 Thanks for opening the PR @yanghua. I would need some input from @twalthr or @fhueske whether it already makes sense to include the Flink table example programs in Flink's binary distribution.

[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...

2018-06-13 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6123 cc @dawidwys can you review this? ---

[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...

2018-06-11 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6123 cc @fhueske can you review this PR? ---

[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...

2018-06-08 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6123 @twalthr can you have a look? ---

[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...

2018-06-05 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6123 cc @twalthr ---

[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...

2018-06-05 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6123 Please provide a reasoning when opening JIRAs, i.e. the answer to "Why should we make this change?". ---