[GitHub] flink issue #6228: [FLINK-9491] Implement timer data structure based on Rock...

2018-07-03 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6228 @sihuazhou @azagrebin thanks for the reviews! I will merge this once my travis is green. ---

[GitHub] flink issue #6228: [FLINK-9491] Implement timer data structure based on Rock...

2018-07-02 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6228 +1 from my side ---

[GitHub] flink issue #6228: [FLINK-9491] Implement timer data structure based on Rock...

2018-07-02 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6228 @sihuazhou thanks for the fast review. I addressed all your comments. ---

[GitHub] flink issue #6228: [FLINK-9491] Implement timer data structure based on Rock...

2018-06-30 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6228 @StefanRRichter very nice PR, I only had some very minor comments. ---

[GitHub] flink issue #6228: [FLINK-9491] Implement timer data structure based on Rock...

2018-06-29 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6228 CC @azagrebin @sihuazhou ---