[GitHub] flink issue #6253: [FLINK-8094][Table API & SQL] Support other types for Exi...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/flink/pull/6253 @xccui Yes. Without defining expression with custom reserved keyword, we may need to leverage function which would be non-UDF which means we need to add the function to default provided function

[GitHub] flink issue #6253: [FLINK-8094][Table API & SQL] Support other types for Exi...

2018-07-05 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/6253 Hi @HeartSaVioR, really sorry for the late reply. The problem that has always been confusing me is how to configure the date format. Anyway, supporting the standard ISO one is a great first step.

[GitHub] flink issue #6253: [FLINK-8094][Table API & SQL] Support other types for Exi...

2018-07-05 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/6253 Thanks for the update @HeartSaVioR. I'll merge this ---

[GitHub] flink issue #6253: [FLINK-8094][Table API & SQL] Support other types for Exi...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/flink/pull/6253 Btw, looks like it may be also possible for ExistingField to replace needs of ParsingExistingField, via adding optional dateformat parameter (not sure which is more preferred), but I feel we can

[GitHub] flink issue #6253: [FLINK-8094][Table API & SQL] Support other types for Exi...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/flink/pull/6253 @fhueske Thanks for the nice feedback! Addressed your comment except regarding unit test. Let me try out adding unit test later, since it might bring too high barrier as of now. ---