[GitHub] flink issue #6388: [FLINK-6222] Allow passing env variables to start scripts...

2018-07-25 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/6388 Thanks for the review @StefanRRichter and @zentol. Will fix the indentation while merging. ---

[GitHub] flink issue #6388: [FLINK-6222] Allow passing env variables to start scripts...

2018-07-24 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/6388 LGTM, except the one remaining indentation problem mentioned by @zentol . ---

[GitHub] flink issue #6388: [FLINK-6222] Allow passing env variables to start scripts...

2018-07-23 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/6388 In the first place I thought it might make providing the variables a bit more flexible with `flink-env.sh`. In the end it is just a bash script, but the longer I think the more convinced I am it was

[GitHub] flink issue #6388: [FLINK-6222] Allow passing env variables to start scripts...

2018-07-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6388 If a feature isn't visibly documented chances are no one will use it ;) I'm not sure if the configuration page is the right place to put it, as it so far deals exclusively with settings set in

[GitHub] flink issue #6388: [FLINK-6222] Allow passing env variables to start scripts...

2018-07-23 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/6388 I added a small section. I was thorn a little in the first place if we should make it highly visible in docs as it might be wrongly understood those variables will be distributed to the cluster as w