[GitHub] flink pull request: [FLINK-1105] Add support for locally sorted ou...

2015-02-02 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/347#discussion_r23914605 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/DataSink.java --- @@ -83,6 +93,107 @@ public DataSink(DataSetT data, OutputFormatT

[GitHub] flink pull request: [FLINK-1105] Add support for locally sorted ou...

2015-02-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/347#discussion_r23914766 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/DataSink.java --- @@ -83,6 +93,107 @@ public DataSink(DataSetT data, OutputFormatT

[GitHub] flink pull request: [FLINK-1105] Add support for locally sorted ou...

2015-02-02 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/347#issuecomment-72430165 The change is good to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1105] Add support for locally sorted ou...

2015-02-02 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/347#issuecomment-72501446 @rmetzger thanks for the feedback. I addressed your comment. Plan to merge this tomorrow, unless somebody objects. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1105] Add support for locally sorted ou...

2015-01-29 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/347 [FLINK-1105] Add support for locally sorted output You can merge this pull request into a Git repository by running: $ git pull https://github.com/fhueske/flink locallySortedOutput