[GitHub] flink pull request: [FLINK-1471][java-api] Fixes wrong input valid...

2015-02-05 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/359#issuecomment-73042551 Skipping the validation on raw types makes total sense. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-1471][java-api] Fixes wrong input valid...

2015-02-05 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/359#issuecomment-73013430 I do not quite get what this means now for the input validation. Assume two classes, `A` and `B`, where `B` is a subclass of `A`. ```java DataSetB data

[GitHub] flink pull request: [FLINK-1471][java-api] Fixes wrong input valid...

2015-02-04 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/359#discussion_r24085603 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -680,10 +680,20 @@ private static void

[GitHub] flink pull request: [FLINK-1471][java-api] Fixes wrong input valid...

2015-02-04 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/359#discussion_r24085111 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -680,10 +680,20 @@ private static void

[GitHub] flink pull request: [FLINK-1471][java-api] Fixes wrong input valid...

2015-02-04 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/359#discussion_r24085204 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -680,10 +680,20 @@ private static void