Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/664#discussion_r30391422
--- Diff: docs/apis/best_practices.md ---
@@ -0,0 +1,155 @@
+---
+title: Best Practices
+---
+!--
+Licensed to the Apache Software Foundation
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/664#discussion_r30392459
--- Diff: docs/apis/best_practices.md ---
@@ -0,0 +1,155 @@
+---
+title: Best Practices
+---
+!--
+Licensed to the Apache Software
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/664#issuecomment-102312636
Thanks for the docs update! Very nice idea with the best practices page. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/664#discussion_r30392111
--- Diff: docs/apis/programming_guide.md ---
@@ -665,6 +667,18 @@ DataSetInteger result = in.partitionByHash(0)
/td
/tr
tr
+
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/664#discussion_r30391587
--- Diff: docs/apis/best_practices.md ---
@@ -0,0 +1,155 @@
+---
+title: Best Practices
+---
+!--
+Licensed to the Apache Software Foundation
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/664#issuecomment-102315511
Thanks for the review Henry and Ufuk!
I addressed your concerns and updated the PR.
I rebased the PR to the current master and filed two JIRAs for missing
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/664#discussion_r30391280
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/664#discussion_r30391850
--- Diff: docs/apis/best_practices.md ---
@@ -0,0 +1,155 @@
+---
+title: Best Practices
+---
+!--
+Licensed to the Apache Software Foundation
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/664#discussion_r30392280
--- Diff: flink-runtime/src/main/resources/log4j.properties ---
@@ -18,7 +18,7 @@
# Convenience file for local debugging of the
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/664#issuecomment-102327285
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/664#discussion_r30391338
--- Diff: flink-runtime/src/main/resources/log4j.properties ---
@@ -18,7 +18,7 @@
# Convenience file for local debugging of the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/664#discussion_r30391736
--- Diff: docs/apis/programming_guide.md ---
@@ -665,6 +667,18 @@ DataSetInteger result = in.partitionByHash(0)
/td
/tr
tr
+
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/664#issuecomment-102383548
Okay .. merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/664
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/664#discussion_r30342062
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/664#issuecomment-102111410
Hi @rmetzger, just did a pass and other than comments about unused test and
broken Travis due to check style I think this PR is ready to go. +1
---
If your project is
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/664#issuecomment-101579496
Do you want to allow empty keys like in `-- value` or even `--`? I think
the parser should throw an exception in this case.
---
If your project is set up for it, you can
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/664#issuecomment-101303549
Yes. But my PR will provide two standard implementations (ParameterTool,
Configuration), so only if users want more features they need to implement the
config.
18 matches
Mail list logo
