Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/479#issuecomment-82539185
Looks nice, +1 to add this.
Also, +1 to add the JIRA issue number to the commits and squash some basic
cleanup commits.
---
If your project is set up for
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/479
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/479#issuecomment-82391642
I added the missing Scala docs. If there are no objections, then I would
merge the PR once Travis has passed.
---
If your project is set up for it, you can reply to
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/479#issuecomment-82392282
merge it.
To get some bonus points, include the JIRA id with the commits
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26506880
--- Diff: docs/ml/alternating_least_squares.md ---
@@ -0,0 +1,157 @@
+---
+mathjax: include
+title: Alternating Least Squares
+---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26506950
--- Diff: docs/ml/alternating_least_squares.md ---
@@ -0,0 +1,157 @@
+---
+mathjax: include
+title: Alternating Least Squares
+---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26507028
--- Diff: docs/ml/polynomial_base_feature_mapper.md ---
@@ -0,0 +1,91 @@
+---
+mathjax: include
+title: Polynomial Base Feature Mapper
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26526474
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/common/FlinkTools.scala
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/479#issuecomment-78909506
But let's do it on the u...@flink.apache.org mailing list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/479#issuecomment-78909366
@junwucs great to here that you're using the ALS implementation. Could you
give us some more information about the occurring error? Curious to understand
why you saw
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/479#issuecomment-79001996
Really great work @tillrohrmann!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26388420
--- Diff: docs/ml/polynomial_base_feature_mapper.md ---
@@ -0,0 +1,91 @@
+---
+mathjax: include
+title: Polynomial Base Feature Mapper
+---
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26388007
--- Diff: docs/ml/alternating_least_squares.md ---
@@ -0,0 +1,157 @@
+---
+mathjax: include
+title: Alternating Least Squares
+---
+!--
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26387939
--- Diff: docs/ml/alternating_least_squares.md ---
@@ -0,0 +1,157 @@
+---
+mathjax: include
+title: Alternating Least Squares
+---
+!--
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26388040
--- Diff: docs/ml/alternating_least_squares.md ---
@@ -0,0 +1,157 @@
+---
+mathjax: include
+title: Alternating Least Squares
+---
+!--
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26388389
--- Diff: docs/ml/polynomial_base_feature_mapper.md ---
@@ -0,0 +1,91 @@
+---
+mathjax: include
+title: Polynomial Base Feature Mapper
+---
Github user junwucs commented on the pull request:
https://github.com/apache/flink/pull/479#issuecomment-78765829
Hi, tillrohrmann! It's a great job! I am interested in ALS implementation
and preparing to use it in our work. Recently I worked on branch of
Github user junwucs commented on the pull request:
https://github.com/apache/flink/pull/479#issuecomment-78766228
Hi, @tillrohrmann, it's a great job! I am interested in ALS implementation
and preparing to use it in our work. Recently I worked on branch of
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/479#issuecomment-78709707
I filed the corresponding JIRA issues. I'll update the commits with the
respective JIRA tags once the PR will be merged.
---
If your project is set up for it, you
19 matches
Mail list logo
