[GitHub] flink pull request: [FLINK-1774]Remove the redundant code in try{}...

2015-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-1774]Remove the redundant code in try{}...

2015-03-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/522#issuecomment-85425753 Looks good, the finally block actually takes care of the cleanup. +1 to merge --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-1774]Remove the redundant code in try{}...

2015-03-23 Thread matadorhong
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/522 [FLINK-1774]Remove the redundant code in try{} block. Remove the redundant code of fos.close(); fos = null; in try block because the fos,close() code will always executes in finally block. You