[GitHub] flink pull request: [FLINK-1923] Replaces asynchronous logging wit...

2015-04-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/628 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-1923] Replaces asynchronous logging wit...

2015-04-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/628 [FLINK-1923] Replaces asynchronous logging with synchronous logging in actors Replaces asynchronous logging with synchronous logging in actors. Additionally, all Scala implementations are now

[GitHub] flink pull request: [FLINK-1923] Replaces asynchronous logging wit...

2015-04-27 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/628#discussion_r29140183 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -357,16 +356,6 @@ protected void unregisterTask() {

[GitHub] flink pull request: [FLINK-1923] Replaces asynchronous logging wit...

2015-04-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/628#issuecomment-96622572 I am curious, why did you rewrite the TaskManager? I thought that one was logging synchronously already. --- If your project is set up for it, you can reply to this